MSM delay: crashes hosting daw when used in VST

netboy3 / MSM-vcvrack-plugin

VCV Rack Modules: MSM

MIT License

11 stars 2 forks source link

MSM delay: crashes hosting daw when used in VST #7

Closed Eurikon closed 2 years ago

Eurikon commented 2 years ago

Hi,

i just encountered the following, that i been able to replicate with several DAW hosts.

First create a new template for VCV Rack, a blank empty template with only MSM delay in it (i haven't checked the other MSM modules). Save it as template for VCV.

Close VCV

Open any daw, (i tested Ableton, Bitwig and Reason) , in the daw load VCV vst, it will crash the host. Bitwig will sandbox the VST, the other 2 crashed.

netboy3 commented 2 years ago

Thanks for the feedback. This is all very new. MSM was never tested inside a VST. It will take me some time to setup a proper VST testing environment.

Eurikon commented 2 years ago

Yeah i understand, i wish there was a trace in the log, but nothing in there.

netboy3 commented 2 years ago

I verified the problem and believe I got it fixed. The following seems to be working well for me. Would you mind testing this and let me know if it's working well for you? Once testing is complete, I'll push the fix out. Attached is a zip file, inside it are three plugins for each of the platforms.

Close Rack2 (and the VST)
Drop the proper vcvplugin file in the plugins folder inside your Rack2 user folder
Delete the MSM folder in the plugins folder inside your Rack2 user folder.

MSM-2.0.1.d.zip

cschol commented 2 years ago

Your plugin stores references to custom fonts across frames. This leads to crashes in the VST when reloading a project.

Please see the following link on how to resolve this issue and re-submit to the Library: https://vcvrack.com/manual/Migrate2#2-1-Don-t-store-Font-and-Image-references-across-multiple-frames

netboy3 commented 2 years ago

Yup. I'll push an update today.

netboy3 commented 2 years ago

Fixed in commit 0f2cb2bc006625e8e464d5ea5ea50066ca93ae96