netbrain / zwift

Easily zwift on linux
The Unlicense
265 stars 28 forks source link

[ doc ] note for strong passwords #31

Closed gallais closed 1 year ago

gallais commented 1 year ago

Passwords using special characters need escaping. Otherwise authentication just fails because the variable only got assigned part of the password.

quietvoid commented 1 year ago

Maybe the credentials variables example can be updated to use single quotes? That would avoid the need for escaping.

ZWIFT_PASSWORD='password'
gallais commented 1 year ago

Except if the password also contains single quotes. :grin:

quietvoid commented 1 year ago

Right, but it would be specific to the single quote case, and would still be better than the current example that isn't using quotes at all. So just a suggestion if you want to update the PR, otherwise I might do it later.

netbrain commented 1 year ago

Doesn't this go without saying when things are stored in env vars? Or is this just me?

gallais commented 1 year ago

I guess the question is whether we are expecting all users to be devs.

netbrain commented 1 year ago

I guess the question is whether we are expecting all users to be devs.

Fair enough