Closed hobeone closed 4 months ago
On Tue, Apr 23, 2024 at 1:58 PM Kim Eik @.***> wrote:
@.**** approved this pull request.
Think this is good now, but haven't tested it. Good job 🤗.
It works on my machine :)
Thanks for working through the pull request.
— Reply to this email directly, view it on GitHub https://github.com/netbrain/zwift/pull/94#pullrequestreview-2018289724, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2I63HJSLPD6Y2DMVN2P2DY63DQLAVCNFSM6AAAAABGQA7RBOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJYGI4DSNZSGQ . You are receiving this because you authored the thread.Message ID: @.***>
-- Daniel Hobe @.***>
FYI. https://github.com/netbrain/zwift/commit/0c614eab2eaa725299e96f5c67d1429aa55af9c7
Added the missing file to the push workflow.
Ah, the push workflow seems to have failed due to not handling missing files in container. But ill just build the entire image from scratch instead. This will however cause everyone to have to download full image, and not only the recent changes.
First pass at this and my first time messing with this level of Docker config so may have missed something obvious.
I've gotten the image to build but when I try to docker run it it keeps reinstalling zwift from scratch. All the permissions are changed appropriately and I don't see any obvious error messages.