search

netbymatt / ws4kp

WeatherStar 4000+
https://weatherstar.netbymatt.com
MIT License
263 stars 44 forks source link

Update the script to build the css and minimize it to work with the files checked in #30

Closed hokey closed 1 year ago

hokey commented 1 year ago

I was running into issues starting fresh locally working with the CSS and noticed that the script for building the css didn't point to the write files or included the compressed style of the finished output. This should fix that part.

netbymatt commented 1 year ago

I like this idea. It exposed a potential hole in my build and upload process that uses gulp.

My normal development cycle uses VSCode and I've just got sass watching for changes. Then my gulp upload task can just grab the pre-compiled scss.

Would you be ok with this becoming a gulp task, and then including it in npm scripts as your pull request has?

netbymatt commented 1 year ago

Well... Moving it to gulp was a good idea but gulp-sass and the live sass compile extension in VS code produce every so slightly different css. One liked to add a few -webkit vendor prefixes, and the other -moz. It would be a lot of diff churn and I don't feel like sorting out exactly why they're slightly different.

I'll go ahead and merge your fix.