search

netceteragroup / react-native-twitterkit

A React Native wrapper around Fabric's TwitterKit.
MIT License
22 stars 10 forks source link

[bug] android display cached version of tweet #13

Closed thedgbrt closed 6 years ago

thedgbrt commented 7 years ago

There used to be a fix for it in TweetView.java, in a previous version.

Since then, the method for displaying a tweet in Android changed, and the fix is gone. I get the bug very often.

Is there a way to fix it? I can take a stab at it if somebody guides me with the approach, as I'm not an Android developer at all.

28084840-35a64268-667a-11e7-8774-bfbf9ade150f

ognen commented 7 years ago

Hi @thedgbrt,

Thank you for your report. I assume you are referring to the bug where the image isn't showing properly, correct?

We ware moving to TwitterKit version 3, major change; as soon as I merge the pull requests I will let you know so you can re-test this issue. If it shows up with the newer twitter kit, we will investigate further.

thedgbrt commented 7 years ago

@ognen nope, the tweet that you see here is not the one i loaded, it's the one from the initializer. https://github.com/netceteragroup/react-native-twitterkit/blob/0a219af66a75d9967746f1f1b96c2f3a4367b22e/android/src/main/res/layout/tweet_container.xml

It happens from time to time when I load the app, and I noticed that in a previous version of the repo, it was a know issue, with a workaround for it (see line 23).

Since TweetView has been refactored, the bug happens again.

(really cool that you're upgrading to twitterKit 3 👍, i'm thankful for all the work that's been done already)

ognen commented 7 years ago

@thedgbrt, yes, there is a fix for that in the #14 pull request (it wasn't done separately). Expect that TwitterKit 3.0 lands next week as soon as I verify that iOS / Android PRs work as expected.

thedgbrt commented 7 years ago

@ognen brilliant! thanks for pointing it out :)