netceteragroup / skele

Architectural framework that assists building data-driven apps with React or React Native.
MIT License
163 stars 32 forks source link

feat(components): Add retainOnceInViewport prop to Viewport.WithPlaceholder #111

Closed bevkoski closed 6 years ago

bevkoski commented 6 years ago

This feature is inspired by a Medium comment.

It adds support for keeping a component wrapped by Viewport.WithPlaceholder displayed once it enters the viewport.

With retainOnceInViewport set to false (default behavior), the component will be replaced by a placeholder once it leaves the viewport. With retainOnceInViewport set to true, the component will be kept displayed.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 335


Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/components/src/viewport/withPlaceholder/index.js 0 4 0.0%
<!-- Total: 0 4 0.0% -->
Files with Coverage Reduction New Missed Lines %
packages/components/src/viewport/withPlaceholder/index.js 1 0.0%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 334: -0.6%
Covered Lines: 852
Relevant Lines: 1030

💛 - Coveralls