Added Java 8 compatibility.

[robert-iddink]

Some minor change to get it working with Java 8.

[buildhive]

Netcetera » valdr-bean-validation #85 FAILURE Looks like there's a problem with this pull request (what's this?)

[robert-iddink]

The build failed, because it ran with JDK7.

[robert-iddink]

@marcelstoer Can you have a look at this PR? Thanks!

[buildhive]

Netcetera » valdr-bean-validation #87 FAILURE Looks like there's a problem with this pull request (what's this?)

[buildhive]

Netcetera » valdr-bean-validation #88 FAILURE Looks like there's a problem with this pull request (what's this?)

[buildhive]

Netcetera » valdr-bean-validation #89 FAILURE Looks like there's a problem with this pull request (what's this?)

[marcelstoer]

Sorry, I totally forgot about this PR. Thanks for the reminder. I can (and should) add Java 8 compatibility but there are three issues with this PR:

• whitespace
• import ordering
• JVM target version must remain at 1.7 because I don't want to drop Java 7 support yet

[robert-iddink]

OK, I'll try to fix those first. Thanks for your quick reply!

[coveralls]

Coverage increased (+0.19%) to 90.6% when pulling b3703707b60244bed65964c96051dc8dcc05c8f7 on Arzie:master into 326986475e596401eb24f512e5c9ac8c2e58b91b on netceteragroup:master.

[buildhive]

Netcetera » valdr-bean-validation #90 UNSTABLE Looks like there's a problem with this pull request (what's this?)

[robert-iddink]

There we go ;-). Did I fix the whitespace issue (I'm not sure where the problem was)?

[buildhive]

Netcetera » valdr-bean-validation #91 SUCCESS This pull request looks good (what's this?)

[robert-iddink]

OK, so either the buildhive build passes (which runs on Java 1.7), or the Travis build passes (which runs on 1.8). I'll apply the test fixes once more, so the build will pass on Java 1.8 (which we're targeting anyway).

[buildhive]

Netcetera » valdr-bean-validation #92 UNSTABLE Looks like there's a problem with this pull request (what's this?)

[buildhive]

Netcetera » valdr-bean-validation #93 UNSTABLE Looks like there's a problem with this pull request (what's this?)

[coveralls]

Coverage increased (+0.19%) to 90.6% when pulling c2ec06e449926d5c1d4ddcdd3ccc94b6589d7914 on Arzie:master into 326986475e596401eb24f512e5c9ac8c2e58b91b on netceteragroup:master.

[robert-iddink]

@marcelstoer I think I fixed the issues, can you have another look?

The tests still give some trouble, maybe they should be made more stable somehow? They're dependent on the exact form of the JSON, which seems to change from build to build.

[marcelstoer]

I'm taking a look now but you certainly can't run a Maven build targeting Java 8 with a Java 7 compiler. For Travis this information is in .travis.yml for BuildHive and drone.io it's in the build job configuration.

[robert-iddink]

Well, the pom.xml now targets 1.7 again, so that should work fine. I updated the Travis config file to make it run on JDK 8, but I can't change the BuildHive config.

[marcelstoer]

@Arzie Given that

• any Java 7 code will run on a JVM 8
• you cannot compile Java 8 code to run on a JVM 7 (i.e. javac Test -source 1.8 -target 1.7 doesn't work)
• you essentially just updated reflections.version from 0.9.8 to 0.9.9

I was wondering what you really were trying to accomplish. Is reflections 0.9.9 required if you want to run on a JVM 8? I didn't find any such reference in their documentation.

[robert-iddink]

The main change is indeed the version of the reflections dependency. If I remember correctly this was the issue we had with it: https://code.google.com/p/reflections/issues/detail?id=169

So if you're trying to analyse Java 8 sources with valdr-bean-validation, you're not getting the results you want.

[marcelstoer]

Ahh, thanks for the link to that issue. I only checked their issues on GitHub. And thanks for pointing out the problems with that unit test. I played around with different JDKs and can confirm that the order of the JSON attributes changes. I'll fix that.

[robert-iddink]

Thanks Marcel!

[marcelstoer]

I just released 1.1.1, should show up in Maven Central shortly.

[robert-iddink]

Cool, I'll start using it right away ;-).