search

netceteragroup / valdr

A model centric approach to AngularJS form validation
http://netceteragroup.github.io/valdr/
MIT License
153 stars 43 forks source link

fix(valdr-message): handle $translate promise rejection (in Angular 1… #120

Closed christophercr closed 7 years ago

christophercr commented 7 years ago

….6+ ALL promise rejections should be handled)

Since Angular 1.6+, all possible promise rejections should be handled, otherwise a "Possible unhandled rejection..." error is thrown.

This feature is enabled by default: https://code.angularjs.org/1.6.4/docs/api/ng/provider/$qProvider

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 60c0cc01e5ea481a02d4ede3ef7d49e7e36548b4 on christophercr:master into 897b80bffb0fb4c11d1014bc957831f60ddec601 on netceteragroup:master.

christophercr commented 7 years ago

Fixes #121

B8li commented 7 years ago

Thx, looks great !

nicogarcia commented 6 years ago

Great, is this going to be released soon? thanks!