valdr-message throws "Possible unhandled rejection..." in Angular 1.6: $translate promise rejection not handled

netceteragroup / valdr

A model centric approach to AngularJS form validation

http://netceteragroup.github.io/valdr/

MIT License

153 stars 43 forks source link

valdr-message throws "Possible unhandled rejection..." in Angular 1.6: $translate promise rejection not handled #121

Closed christophercr closed 7 years ago

christophercr commented 7 years ago

The updateTranslations() function inside the valdrMessage directive uses the $translate service to get some translations. This call return a Promise which can be either resolved or rejected. Obviously the function just cares about the successful result, which is handled, however the rejection is not handled.

This is now being thrown as an error in Angular 1.6+ by default (see https://code.angularjs.org/1.6.4/docs/api/ng/provider/$qProvider)

christophercr commented 7 years ago

@philippd, @marcelstoer Could you maybe have a look on this?

B8li commented 7 years ago

@christophercr, PR is looks good and it's merge. Thx for fixing the issue.