netconf-wg / restconf

9 stars 4 forks source link

TP Review of draft-10 part1 #57

Closed abierman closed 8 years ago

abierman commented 8 years ago

It's BIG (which means I include comments up to the end of section 3 now and hope to send the rest next week; questions of clarity, mostly).

I do like section 1, much more to my taste.

-s1.4 " If the device supports :startup, the device automatically copies the " sounds like a MUST

"MUST

"This timestamp is only affected by configuration data resources, and MUST NOT be updated for changes to non-configuration data."

Which timestamp? resource timestamp for the datastore? Since it is a new paragraph, I am unclear.

"If not maintained, then the resource entity tag for the datastore MUST be used instead.

This entity tag is only affected by configuration data resources, and MUST NOT be updated for changes to non-configuration data"

Same pair of questions

"and the leaf has not been given a value yet, .. "

Do these mean that it has not been configured? If so, I would find it clearer if it said 'configured'; if not, I am unclear of the nuance.

"If the "input" section contains mandatory parameters, then a message-body MUST be sent by the client."

6020bis says " If a leaf in the input tree has a "mandatory" statement with the value "true", the leaf MUST be present in an RPC invocation. which I think more precise. Suggest something like

" If a leaf in the input tree has a "mandatory" statement with the value "true", the leaf MUST be present in an RPC invocation and a message-body MUST be sent by the client."

s3.6.1 " POST /restconf/data/example-action:interfaces/interface=eth0 ..." " { "example-action:input" : { ..."

module name is 'example-actions'

s3.6.2 " The server might respond:

  HTTP/1.1 200 OK
  Date: Mon, 25 Apr 2012 11:10:30 GMT
  Server: example-server
  Content-Type: application/yang.operation+json
  {   "example-actions:output" : {
      "last-reset" : "2015-10-10T02:14:11Z"     }    } "

How does the client marry the output to the request? Should the rest of the path be there? interfaces/interface=eth0/get-last-reset-time

Tom Petch

abierman commented 8 years ago

issues addressed in restconf-12