netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

Hangup if you try and navigate away while editing an Edge #101

Closed jdanish closed 4 years ago

jdanish commented 4 years ago

Steps to reproduce:

Approach 1

  1. Create node
  2. Add edge
  3. Change mind, cancel edge entry
  4. Edge doesn't go away
  5. Hit delete
  6. Edge source/target blank now, but edge listing doesn't go away and stops other text fields from functioning.
  7. Reloading makes the blank edge go away and now text fields are behaving the way the should.

Approach 2

    • Click on a node
    • Add new edge
    • Cancel edge entry
    • Ghost edge remains in the edge list
    • ((editing is locked now, cant type in node search)
    • Click create new node
    • ((things unlock now))
    • Cancel create node
    • Ghost edge is gone now
benloh commented 4 years ago

This is related to #96

benloh commented 4 years ago

Fixed with 25774884126a87910972be69bb81ce58f2ea9905

Canceling a new unsaved edge now properly removes the new edge component and restores the node editor state and search field state.