jdanish
commented
4 years ago I assume this will be revisited in a future implementation.
Open benloh opened 4 years ago
jdanish
commented
4 years ago I assume this will be revisited in a future implementation.
Date filtering still needs to be implemented.
For the dates, a library and validation long-term would be great, but for now if we can convince them to use a decent format (and then clean it up as needed), and then we just do normal less / more won't it be handled naturally? We'd have to do cleanup for the inevitable kid who puts a date in the wrong, but otherwise, I think that'd work. So, for example, if the format is YYYY/MM/DD then 2019/01/01 is less than 2020/01/01 and 2020/01/01 is less than 2020/01/02 using basic string comparison, no? Naturally, kids not putting leading zeros causes problem that we'll want to solve later with validation and a library etc., but short term we can edit.
Incidentally, the timeline / dates is where I imagine actually removing nodes that are not yet present is really powerful because you'd see the node sizes change over time as they shift who they are connected to.