search

netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

Version 1.3.0 to Master #127

Closed benloh closed 4 years ago

benloh commented 4 years ago

Version 1.3.0. See Release notes from #123

benloh commented 4 years ago

@jdanish I'm merging dev into master for the 1.3.0 release. If you need to pull prior releases you can pull based on tags. Looks like github requires one other person to approve before it can be merged. The release notes are all in #123. I will tag this as 1.3.0 after the merge into master.

Also, I've deleted the config-ip-* branches to keep things pruned. If you're on those branches for DO, you'll want to switch to dev.

jdanish commented 4 years ago

Looks good. I think that this will approve it, but if not let me know.

jdanish commented 4 years ago

That didn't do it. Looking for how now ...

benloh commented 4 years ago

If you're testing tonight I may as well wait until you're done. I just didn't want to leave this dangling.

On Tue, Aug 25, 2020 at 8:10 AM Joshua Danish notifications@github.com wrote:

@jdanish approved this pull request.

OK! Approving based on earlier testing. I'll actually test this more closely tonight but assume we are good or can roll back using tags.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/netcreateorg/netcreate-2018/pull/127#pullrequestreview-474579984, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKWRMIFQSDOCXUNLJIIMM3SCPH5RANCNFSM4QKYAXTQ .

jdanish commented 4 years ago

Looks good to me. I have only run it locally, but that’s usually a good sign. Let’s go ahead and close it out. I’ll upload to DO tonight but don’t anticipate problems. Thanks!!

Joshua

Joshua A. Danish (he, him, his) (https://www.mypronouns.org/ https://www.mypronouns.org/)

jdanish@gmail.com

http://www.joshuadanish.com

On Aug 25, 2020, at 11:29 AM, benloh notifications@github.com wrote:

If you're testing tonight I may as well wait until you're done. I just didn't want to leave this dangling.

On Tue, Aug 25, 2020 at 8:10 AM Joshua Danish notifications@github.com wrote:

@jdanish approved this pull request.

OK! Approving based on earlier testing. I'll actually test this more closely tonight but assume we are good or can roll back using tags.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/netcreateorg/netcreate-2018/pull/127#pullrequestreview-474579984, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKWRMIFQSDOCXUNLJIIMM3SCPH5RANCNFSM4QKYAXTQ .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/netcreateorg/netcreate-2018/pull/127#issuecomment-680097209, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKGCKSLQ54U4TLSZTFNZVLSCPKE3ANCNFSM4QKYAXTQ.