search

netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

Node and Edge tables disappear #137

Closed jdanish closed 3 years ago

jdanish commented 3 years ago

If you load a network and click on the node or edge table they appear as expected. Then, click on a node in the graph to select it. If you now click on the node or edge tab the tables are empty.

benloh commented 3 years ago

Actually I think this is an error where reselecting a nodetable or edgetable does not update the data.

benloh commented 3 years ago

Degrees seem to not update either...

benloh commented 3 years ago

This was being caused by the bMarkedNode optimization skipping D3DATA updates. NodeTables and EdgeTables wouldn't re-render themselves if a node was selected.

The bMarkedNode optimization to skip table updates when a node is selected would also prevent the tables from rendering when switching tab panels.

If it's necessary to skip a render on selection, the check should be made on selection state.

Hopefully with the table optimizations this is no longer necessary.

Fixed with 0e4a15f78bee38ac0f4d112dd99be6319be4daa7 See also #136.