search

netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

It is possible to create a node with no label, which crashes the node table #144

Open jdanish opened 3 years ago

jdanish commented 3 years ago

I noticed this in our log:

04:34:09 H213FA20201348 UADDR_166 [H213-1348-M8V] insert node 184 {"id":184,"attributes":{"Node_Type":"Author","Extra Info":"Louis Sanctus (Aberth 02.04)","Notes":"Louis Sanctus seems to have experience in medical testimonys "}}

And was able to reproduce it. Click "add new node" and then simply fill out the rest and save. It creates fine, and all works except the nodes table.

We should either not allow submission (long-term goal) or make the node table read it just fine (short-term fix).

benloh commented 3 years ago

There was validation against blank labels, but adding the delete functionality broke this. See onReplacementNodeIDChange.

On Fri, Sep 25, 2020 at 9:54 AM Joshua Danish notifications@github.com wrote:

Assigned #144 https://github.com/netcreateorg/netcreate-2018/issues/144 to @benloh https://github.com/benloh.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/netcreateorg/netcreate-2018/issues/144#event-3808585191, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKWRMJASQ7SUMTMTQ3BYATSHTDMLANCNFSM4RZYKOTQ .

jdanish commented 3 years ago

OK. I added some error checking so that this won't crash it anymore, but we should review and ideally change this to include validation in the future.

benloh commented 3 years ago

@jdanish I think I found the problem: our validation checker was not also catching an undefined label. It should be fixed now: The "Save" button should now be disabled if the label is blank. See 9207a2b23fe69f348c61b174d990553291f133f6

If that solves the problem we should merge request this and update the tag to v1.3.2, so we don't leave this dev branch hanging. (Unless you plan on doing other work in the immediate future)