search

netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

Selecting a node re-sorts node table #147

Closed jdanish closed 3 years ago

jdanish commented 3 years ago

Click to sort node table by type, it works Select a node and click it It is selected, but the table appears to re-sort

benloh commented 3 years ago

Also, degrees seems to do a recount, doubling with each click. It's possible the click is bubbling up. But the recount issue might be a render issue. Taking a quick look.

jdanish commented 3 years ago

Ben - I fixed the counting in my most recent commit. Thanks!

benloh commented 3 years ago

@jdanish since you're working on this already...I think the problem is NodeTable.js line 96.

const nodes = this.sortTable('label', data.nodes);

This should probably be

const nodes = this.sortTable(this.state.sortkey, data.nodes);

benloh commented 3 years ago

Looks like I probably inserted a shortcut to sort by label while I was optimizing and forgot to fix it.

jdanish commented 3 years ago

That was it, thanks! Fixed in most recent commit with https://github.com/netcreateorg/netcreate-2018/commit/a8eb83a861bf1b62785e30df0a34604013663070