search

netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

Offset node labels based on diameter #152

Open benloh opened 3 years ago

benloh commented 3 years ago

Node labels are hard to read when they overlap the node, especially if a node is selected and has a thick outline.

Possible solutions:

jdanish commented 3 years ago

Do you mean outlined text or like a "badge" (rectangle behind text). I'd be up for trying either/both to see for sure.

benloh commented 3 years ago

I was thinking outlined text. I think it'd be confusing to have another rectangle shape.

On Mon, Nov 9, 2020 at 11:22 AM Joshua Danish notifications@github.com wrote:

Do you mean outlined text or like a "badge" (rectangle behind text). I'd be up for trying either/both to see for sure.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/netcreateorg/netcreate-2018/issues/152#issuecomment-724224716, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKWRMPZEATKODMFQ7VHYJLSPA6NVANCNFSM4TPYBQBQ .

jdanish commented 3 years ago

Yeah, that makes sense. Definitely worth testing at some point.

jdanish commented 3 years ago

After some tinkering, the text outline didn't work well because the stroke presses in as well as out making the font less readable. Changing the selected color to an orange worked great, though. Posted in current branch (dev-jd/filter)

jdanish commented 3 years ago

Note that I also updated this so that the color can be set in the template, allowing you to pick outline colors that mirror your node choices. To-do: update the default template. It is backwards compatible, though - pulling a default if there is nothing in the template.