netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

When starting, the edge table displays as if there is a filter #180

Closed jdanish closed 2 years ago

jdanish commented 2 years ago

This is using the export branch, but may be in earlier builds

To reproduce:

  1. Open net.create
  2. Click on edges tab
  3. Note that several rows are transaprent
  4. Click on filter tab
  5. Clear filters (even though none are displayed as on)
  6. Go to edges tab and table displays correctly
benloh commented 2 years ago

This should be fixed with 6868516b1b1046110bc85eec2751a207da16fcbb

The problem was that edge.source and edge.target is initially stored as a simple numeric id reference. Only after D3 processes the data do the edge.source and edge.target objects become nodes. So the filter logic mistakenly thought the edge's source/targets had been filtered out, so it unhighlighted the edge. This is an annoying bit of how D3 does things that has bitten us multiple times in the past.

jdanish commented 2 years ago

That's annoying! Looks fixed, though! Thanks!

benloh commented 2 years ago

Fixed with #179