search

netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

citationPrompts.hidden used to override citation? #192

Closed benloh closed 2 years ago

benloh commented 2 years ago

@jdanish I'm cleaning up templates. Do you actually use citationPrompts.hidden in your template definitions to actually hide the citation prompt? e.g. you might define the citationPrompt.citation as H213 Prokopios Network, but then set hidden to true so that it isn't shown?

Or were you using the hidden flag just as a way to hide the citation if it's missing?

netcreateorg commented 2 years ago

The hidden option turns off the display of the cite button. So I don't think there is any reason to have a prompt / label and hidden set to true. Unless you want to temporarily turn it off. I suppose we could assume that if there is a prompt it should be visible but this way it is explicit. Default should be that it is hidden: true so there is no cite button.

benloh commented 2 years ago

@jdanish OK, so you prefer to have two separate settings? one to set the label and one to show/hide it?

jdanish commented 2 years ago

For consistency, yes please.

(from my iPhone)

Joshua Danish http://www.joshuadanish.com

On Jan 20, 2022, at 8:47 PM, benloh @.***> wrote:

 @jdanish OK, so you prefer to have two separate settings? one to set the label and one to show/hide it?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.

benloh commented 2 years ago

Implemented.