netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

Auto-scaling markdown images #214

Closed jdanish closed 2 years ago

jdanish commented 2 years ago

Right now images inserted into notes using markdown do not scale and there is no way to scale them. If someone puts in a GIANT one it basically breaks the interface. I think it'd be easy to mod the width on the html img tag that is generated to reflect the width of the notes field on the side bar so this doesn't make everything a big mess? Not a huge issue, but it comes up occasionally.

benloh commented 2 years ago

I wasn't aware that you could insert images :). Do you have an example of a card with an image somewhere?

netcreateorg commented 2 years ago

Well, it's using the markdown plugin, so they aren't inserted so much as referenced. You can see an example on the activity systems node here: http://134.209.73.52/graph/CHAT/#/

Attaching an image in case that url doesn't work later and someone wants to know what was what.

Screen Shot 2022-02-28 at 2 55 06 PM

So this works great, but I had to scale the image down to make it work. Ideally all images would scale as needed.

benloh commented 2 years ago

Fixed with #220.