Closed jdanish closed 2 years ago
Good catch! Should be fixed now with referenced commits above. (It was quicker and more efficient to just fix everything now than to patch in a half-assed fix only to have to come back and redo everything.)
@jdanish Please close if fixed.
Fixed!! Thanks!
Sorry @benloh one minor thing just noticed - if you click view on edge table it opens the node but not the specific edge. If it's a quick fix, cool. If it's a hassle, it can wait for future rounds.
Gah. The non-logged in locking was preventing it from opening when edit was requested. Should be fixed now.
Seems the opposite - it no-longer opens on edit or view?
Crikey. What does the console say? You should see a warning "EdgeEditor.EDGE_EDIT denied because isLocked true but we will gladly show it".
Sorry, missed a line when committing because it had inadvertently gotten pushed behind a debug log. Try again please?
All fixed! Thanks!
Ideally, the edit button in the nodes and edges tables would either not appear or just read "show" or similar when logged out. But currently the nodes edit button works as desired (shows the node, but doesn't allow editing) whereas the edges edit button does allow editing. So if it is faster, just disabling editing would work with a longer-term goal of hiding or changing the text on the buttons.