netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

Edges table edit button works even when not logged in #231

Closed jdanish closed 2 years ago

jdanish commented 2 years ago

Ideally, the edit button in the nodes and edges tables would either not appear or just read "show" or similar when logged out. But currently the nodes edit button works as desired (shows the node, but doesn't allow editing) whereas the edges edit button does allow editing. So if it is faster, just disabling editing would work with a longer-term goal of hiding or changing the text on the buttons.

benloh commented 2 years ago

Good catch! Should be fixed now with referenced commits above. (It was quicker and more efficient to just fix everything now than to patch in a half-assed fix only to have to come back and redo everything.)

benloh commented 2 years ago

@jdanish Please close if fixed.

jdanish commented 2 years ago

Fixed!! Thanks!

jdanish commented 2 years ago

Sorry @benloh one minor thing just noticed - if you click view on edge table it opens the node but not the specific edge. If it's a quick fix, cool. If it's a hassle, it can wait for future rounds.

benloh commented 2 years ago

Gah. The non-logged in locking was preventing it from opening when edit was requested. Should be fixed now.

jdanish commented 2 years ago

Seems the opposite - it no-longer opens on edit or view?

benloh commented 2 years ago

Crikey. What does the console say? You should see a warning "EdgeEditor.EDGE_EDIT denied because isLocked true but we will gladly show it".

jdanish commented 2 years ago
Screen Shot 2022-03-24 at 3 22 39 PM
benloh commented 2 years ago

Sorry, missed a line when committing because it had inadvertently gotten pushed behind a debug log. Try again please?

jdanish commented 2 years ago

All fixed! Thanks!