search

netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

Delete node causes error #235

Closed jdanish closed 2 years ago

jdanish commented 2 years ago

To reproduce, open a network, select a node, click delete (happens with and without merging). There appears to be no change. Check the console and see the error below. Reload and change becomes visible. Note that other viewers don't see a change unless they reload as well.

Screen Shot 2022-03-30 at 5 57 51 PM

benloh commented 2 years ago

Good catch! Fixing now.

jdanish commented 2 years ago

Sorry for the typo in the name.

(from my iPhone)

Joshua Danish http://www.joshuadanish.com

On Mar 30, 2022, at 8:00 PM, benloh @.***> wrote:

 Good catch! Fixing now.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

benloh commented 2 years ago

@jdanish I believe 93bc8539df6259d4d13a7fb4db4fb57474d9dcc6 should fix this. Just pushed. Should be fixed in #217

This was a side effect of our separating the core "raw" data from the "working" filtered data that was necessary to get import/export working. We ended up with a few straggling references to the deprecated data format. I think all the old references are now chased down as well.

jdanish commented 2 years ago

Looks good thanks!