netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

Should Collapse remove nodes from Nodes Table? #269

Closed benloh closed 1 year ago

benloh commented 1 year ago

Currently, when you Highlight or Filter a node, the faded and hidden nodes are still displayed in the Nodes Table formatted as transparent text or red text, respectively.

Collapse is using the same method as Filter: any removed nodes remain in the table with red text.

There are two potential issues:

@jdanish please comment.

jdanish commented 1 year ago

I'd say yes, remove them unless there is a reason not to. I agree with all the confusion it may cause not to.

benloh commented 1 year ago

Addressed by e4fbfd6f0926e51eca1281d11bd06071e798763b and f411ba17e1dcb36be2c7b4bbd098449c3649ba49