Closed benloh closed 1 year ago
@benloh meant to say: this look good. Not 100% how to test those functions in the this note, but I poked around and will continue to do so.
how to test those functions in the this note
Could this be the source of the undefined
popup errors netcreateorg/netcreate-itest#17?
I wouldn't worry about the others. They were mostly a note to myself.
how to test those functions in the this note
Could this be the source of the
undefined
popup errors netcreateorg/netcreate-itest#17?
Those are still happening, so I guess not...
Addresses netcreateorg/netcreate-2018#246
This adds four parameters to the template:
nodeSizeDefault
-- default: 5 -- radiusnodeSizeMax
-- default: 50 -- radiusedgeSizeDefault
-- default: 0.175 -- stroke widthedgeSizeMax
-- default: 25 -- stroke widthAnd also implements the max size limit during drawing with
d3-simplenetgraph
.A few notes:
edgeSizeMax
to be no greater thannodesizeMax * 2
so the link line isn't wider than the node, though it can still be wider than smaller nodes.d3-simplenetgraph
was missing a bunch ofthis
binds, which was probably resulting inundefined
objects. Ini particularly it's worth checking the functionality of the following to see what changes, if any, were found:_ClearSVG
tooltipForNode
displayUpdated
_Transition