search

netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 3 forks source link

Bug Fix: Edge transparency is now properly restored after changing filters. #297

Closed benloh closed 1 year ago

benloh commented 1 year ago

Addresses #296

Edges that were faded by the "Fade" filter would remain faded when switching filters rather than reverting to the default edge transparency as defined in the Template. The easiest test:

  1. Open a graph with two edge types
  2. Select Fade Edge > Type > First Edge Type
  3. Select Reduce
  4. Select Reduce Edge > Type > Second Edge Type
  5. Because the First Edge Type was faded by the Fade filter, they were not being restored to the default transparency. Now with this fix, the Second Edge Type should be visible.

A side effect of this fix is that edge transparency as defined in the Template is now properly and immediately applied before any filters are activated. Prior to this we were not applying the template-defined transparency when filters were activated.

See #296 for testing instructions.

benloh commented 1 year ago

Fixes have been applied to netcreate-itest.