netcreateorg / netcreate-2018

Please report bugs, problems, ideas in the project Issues page: https://github.com/netcreateorg/netcreate-2018/issues
Other
11 stars 2 forks source link

mousedown and click event is very slow on promiscuous nodes #90

Open benloh opened 4 years ago

benloh commented 4 years ago

On tacitus, it takes 2 seconds for the mousedown/click call to register (show the node as selected after clicking on it) on the "Nero" node.

On the other hand, clicking on a non-linked node registers almost immediately

benloh commented 4 years ago

Analyzing the "Nero" click...

Using the Profiler:

0500 ms Event: mousedown is triggered 1600 ms Event: click is triggered 2715 ms Event: click ends 2755 ms Selection is drawn

The mousedown and click events are taking a REALLY long time.

benloh commented 4 years ago

One problem is EdgeEditor renders take a long time, especially if you have a LOT of edges connected to a particular node.

d3c2f4255add2045d47acbf4be29c55072092b5a fixes this by only rendering the minimum edge when in edit mode (instead of rendering the whole edge editor and hiding elements).

This addresses the click event, but mousedown is still slow.