Closed thiagoftsm closed 1 year ago
Just some notes in case any other reviewers need it:
1) Cloned this branch first to a dir (e.g. kernel-collector-324)
2) Downloaded the artifact close to my kernel (artifacts-5.15.63-glibc) into the artifacts/ directory.
3) Did a git submodule update --init --recursive
4) make
and make tester
.
5) Run the tests as root with for i in
seq 0 2; do ./kernel/legacy_test --netdata-path artifacts --content --iteration --pid $i --log-path file_pid$i.txt; done
. The netdata-path
needs to be the path to the artifacts downloaded before.
Artifacts only contains cachestat
, so ignored the errors for not finding the others. For it I got Success:
"/home/evas/tmp/kernel-collector-324/artifacts/rnetdata_ebpf_cachestat.5.15.o" : {
"Test" : "return",
"Tables" : {
"cstat_global" : {
"Info" : { "Length" : { "Key" : 4, "Value" : 8},
"Type" : 6,
"FD" : 5,
"Data" : [
{ "Iteration" : 0, "Total" : 4, "Filled" : 3, "Zero" : 1 }
]
}
},
"cstat_ctrl" : {
"Info" : { "Length" : { "Key" : 4, "Value" : 4},
"Type" : 2,
"FD" : 6,
"Data" : [
{ "Iteration" : 1, "Total" : 2, "Filled" : 2, "Zero" : 0 }
]
}
},
"cstat_pid" : {
"Info" : { "Length" : { "Key" : 4, "Value" : 32},
"Type" : 5,
"FD" : 7,
"Data" : [
{ "Iteration" : 0, "Total" : 0, "Filled" : 0, "Zero" : 0 }
]
}
},
"Total tables" : 3
},
"Status" : "Success"
},
My setup: `Linux 6am 5.15.69-gentoo #1 SMP Sun Oct 9 09:59:07 EEST 2022 x86_64 AMD Ryzen 5 4500U with Radeon Graphics AuthenticAMD GNU/Linux`
"/home/stelios/library/rnetdata_ebpf_cachestat.5.15.o" : {
"Test" : "return",
"Tables" : {
"cstat_global" : {
"Info" : { "Length" : { "Key" : 4, "Value" : 8},
"Type" : 6,
"FD" : 5,
"Data" : [
{ "Iteration" : 0, "Total" : 4, "Filled" : 4, "Zero" : 0 }
]
}
},
"cstat_ctrl" : {
"Info" : { "Length" : { "Key" : 4, "Value" : 4},
"Type" : 2,
"FD" : 6,
"Data" : [
{ "Iteration" : 1, "Total" : 2, "Filled" : 2, "Zero" : 0 }
]
}
},
"cstat_pid" : {
"Info" : { "Length" : { "Key" : 4, "Value" : 32},
"Type" : 5,
"FD" : 7,
"Data" : [
{ "Iteration" : 0, "Total" : 1, "Filled" : 1, "Zero" : 0 }
]
}
},
"Total tables" : 3
},
"Status" : "Success"
},
Approving without reviewing
Summary
This PR is bringing some "small" (RH modified kernel
5.14
and4.18
, so I had to push an additional commit for it.) updates in the code and a documentation to help new eBPF developers (Welcome @stelfrag !).Test Plan
directory
.Success
, unless you do not have a specific target (function) available.Additional information
This PR was tested on:
You can also get all logs here.