netdata / msi-installer

Netdata installer for Windows using WSL2
GNU General Public License v3.0
21 stars 2 forks source link

The installer doesn't work on Windows Server #10

Closed cakrit closed 1 year ago

cakrit commented 1 year ago

We provisioned one (not sure version) that's accessible via RDP. The installer ran, I see NetdataWSL in the programs, but no wsl and no netdata running.

I will send you the rdp credentials @dfpr

dfpr commented 1 year ago

send them, I'll check what happened

cakrit commented 1 year ago

I think that the following may be the issue both for this and for #11

If WSL is not installed, the installer will add it and reboot the server. After restart, run the MSI again manually.

The windows server didn't have WSL AFAIK. The installer didn't reboot the server. Rerunning the same msi twice is a bit counterintuitive. Which which options the first time and which the second?

cakrit commented 1 year ago

Regardless of what the README says, we should make this process as self-evident as possible. rerunning the same thing is a bit confusing. Suggest options and let's see what we'll do.

dfpr commented 1 year ago

I'll test on a fresh server, it is possible the WSL Windows feature installation command for Client editions is different for Server Roles. For the re-run step I'll try putting the installer in the temp dir and set it to run with a RunOnce key in order to finish the installation.

cakrit commented 1 year ago

Sound great, thanks.

dfpr commented 1 year ago

Installer has been updated and does run on Windows Server now.

cakrit commented 1 year ago

I can't get it to work on the server I sent you the RDP info on:

I suspect I screwed something up with the unregister command, but I have no idea how to recover. Can you log in and see if you can figure it out?

dfpr commented 1 year ago

I won't be able today but I think the june update makes the wsl command behavior inconsistent, I'll check with an updated system as soon as I can

dfpr commented 1 year ago

I have added steps in the installer to enable the Virtual Machine Platform feature and install the WSL2 kernel update requirements that were missing for setup on Windows Server. For the machine that was available through RDP, since it is a VM that doesn't have virtualization support and the installer aims to use WSL2, most likely issues will continue in that scenario. Regular non-virtualized Windows Server machines should work.

cakrit commented 1 year ago

In https://github.com/netdata/msi-installer/issues/15 I clarified that supporting WSL1 is inevitable. So please add back the revert to WSL1 if WSL2 fails and retry on this VM. We're working on the netdata bug (not being able to kill netdata) as well.

dfpr commented 1 year ago

In order to fix this I will test in Windows server with the WSL2 update installed and when not and when virtualization is or isn't available so the best route is taken.

cakrit commented 1 year ago

Yes, sounds good. Need any help from me to do that?

dfpr commented 1 year ago

Yes, sounds good. Need any help from me to do that?

I can handle it, thanks.

dfpr commented 1 year ago

This has been fixed.

cakrit commented 1 year ago

Indeed it worked. Attaching the log from our Windows Server which has some confusing errors in it, but is very otherwise very clear about what happened:

netdata.log

I will reinstall once more with the claiming info and close this if everything is ok.

dfpr commented 1 year ago

I'll touch up a little bit the log output for clarity, those arent real errors.

cakrit commented 1 year ago

It worked, the log issue is a different one. There's also a problem in that the installation is no longer unattended, which is going into a new issue I'm opening now.