netdata / msi-installer

Netdata installer for Windows using WSL2
GNU General Public License v3.0
21 stars 2 forks source link

Verify prerequisite? #13

Closed cakrit closed 1 year ago

cakrit commented 1 year ago

Is it possible to warn the user if the prerequisite of the wmi windows_exporter isn't satisfied?

https://learn.netdata.cloud/docs/agent/collectors/go.d.plugin/modules/wmi#requirements

What options do we have?

dfpr commented 1 year ago

I'm thinking of checking if http://localhost:9182/ works, if not installation would intentionally fail. Additionally, setting up an installation log created at %userprofile%\appdata\local\temp (C:\Users\User\AppData\Local\Temp) for troubleshooting a failed installation.

cakrit commented 1 year ago

Do just that for this ticket. I'll add another one to optionally provide a WINDOWS_EXPORTER_URL parameter, as the exporter can optionally be installed on a different port.

cakrit commented 1 year ago

I won't do it now though, let's finish all the other things first.

cakrit commented 1 year ago

Before we do this, a question: I see that it's possible to have msi packages that also install msi packages. I'm not really keen on including whatever the latest windows_exporter msi is as the only way to install, because that would mean we'd have to support all the options they provide as well. So, a nightmare. But perhaps we could do the following?

We would then tell users that for a default windows_exporter installation they just use our msi, but if they want something more advanced, they'll need to install it themselves and give us the URL.

dfpr commented 1 year ago

During a MSI installation Windows Installer blocks concurrent installations so one MSI can't install other, what can be done is pack two or more into an EXE setup file that will install them sequentially, but that wouldn't work for domain policy deployments that can only use MSI.


From: Chris Akritidis @.> Sent: Tuesday, November 1, 2022 2:00:10 PM To: netdata/msi-installer @.> Cc: dfpr @.>; Comment @.> Subject: Re: [netdata/msi-installer] Verify prerequisite? (Issue #13)

Before we do this, a question: I see that it's possible to have msi packages that also install msi packages. I'm not really keen on including whatever the latest windows_exporter msi is as the only way to install, because that would mean we'd have to support all the options they provide as well. So, a nightmare. But perhaps we could do the following?

We would then tell users that for a default windows_exporter installation they just use our msi, but if they want something more advanced, they'll need to install it themselves and give us the URL.

— Reply to this email directly, view it on GitHubhttps://github.com/netdata/msi-installer/issues/13#issuecomment-1298974661, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACFF4DQO2JBNQ6RGPMZQS53WGFSDVANCNFSM6AAAAAARTIDTDY. You are receiving this because you commented.Message ID: @.***>

cakrit commented 1 year ago

Ok, let's forget it. Just the check then. Let's just ensure there's a message the user can see in the log file, if it fails.

dfpr commented 1 year ago

https://github.com/netdata/msi-installer/pull/18 includes the Prometheus windows_exporter dependency

cakrit commented 1 year ago

I verified the installation of windows_exporter on Windows 11 and Windows Server