search

netdata / msi-installer

Netdata installer for Windows using WSL2
GNU General Public License v3.0
21 stars 2 forks source link

Add the other two parameters for claiming #4

Closed cakrit closed 1 year ago

cakrit commented 1 year ago

TOKEN is there, please add ROOMS and URL as well, as per https://github.com/netdata/msi-installer/issues/1#issue-1411973021

Ferroin commented 1 year ago

Note that the URL can (and probably should) default to https://app.netdata.cloud if not supplied (for consistency with our installers on Linux.

dfpr commented 1 year ago

Added the two parameters, rooms and URL in addition to a telemetry control, for claiming only token is mandatory and URL defaults to https://api.netdata.cloud

cakrit commented 1 year ago

Ran it, works fine

cakrit commented 1 year ago

One correction, FYI the default is app.netdata.cloud, not api.netdata.cloud. I added https://github.com/netdata/msi-installer/pull/8 and directly committed a correction to the readme. make sure you fetch before you commit new changes, to prevent conflicts.

Also, a question, how do the properties work regardless of their order? From https://github.com/netdata/msi-installer/blob/master/src/MSIhelper2.cmd#L7 it looks like they must be given in their exact order, i.e. we need all of them, or none of them. But there must be something I missed makes passing just the telemetry parameter work, because I ran the msi just with telemetry=0 and it worked fine.

dfpr commented 1 year ago

One correction, FYI the default is app.netdata.cloud, not api.netdata.cloud. I added #8 and directly committed a correction to the readme. make sure you fetch before you commit new changes, to prevent conflicts.

Also, a question, how do the properties work regardless of their order? From https://github.com/netdata/msi-installer/blob/master/src/MSIhelper2.cmd#L7 it looks like they must be given in their exact order, i.e. we need all of them, or none of them. But there must be something I missed makes passing just the telemetry parameter work, because I ran the msi just with telemetry=0 and it worked fine.

For the MSI the argument order is not important, Windows installer parses them and sets the properties either way, but the helper script uses a strict order set by Windows Installer (https://github.com/netdata/msi-installer/blob/master/src/NetdataWSL%20Windows%20Installer.wxs#L41), that shouldn't be an issue as the cmd is run internally and controlled by Windows Installer.