netdata / msi-installer

Netdata installer for Windows using WSL2
GNU General Public License v3.0
21 stars 2 forks source link

Sign the installer #7

Closed cakrit closed 1 year ago

cakrit commented 1 year ago

I'm purchasing a Windows Code Signing Certificate, so that we don't get warnings from the installer.

I'll send its info privately so we can sign the msi, while we wait for the verification process.

cakrit commented 1 year ago

Actually, @dfpr it's been ages since I last signed an installer, so what will you need from me? The csr and the private key?

dfpr commented 1 year ago

Actually, @dfpr it's been ages since I last signed an installer, so what will you need from me? The csr and the private key?

@cakrit yes, the public-private key pair should be enough to sign the MSI file.

cakrit commented 1 year ago

As we saw, it doesn't seem to work this way and we'll probably need to wait for the Certificate Authority to verify the company. This process is in progress.

cakrit commented 1 year ago

Done.