search

netdata / netdata-cloud

The public repository of Netdata Cloud. Contribute with bug reports and feature requests.
GNU General Public License v3.0
41 stars 16 forks source link

[Bug]: Claiming URL is not set for on-prem deployments using Helm #1028

Open ralphm opened 4 months ago

ralphm commented 4 months ago

Bug description

When using our helmchart, the example commands provided in the UI for adding nodes, both for the Helm and Existing Cluster tabs, do not include the claim URL.

Expected behavior

Include the --parent.claiming.url parameter with the proper claiming URL.

Steps to reproduce

  1. Go to space settings.
  2. Go to the Nodes section.
  3. Click the plus button to add new nodes.
  4. Click on "Kubernetes (Helm)"
  5. Observe missing parameter

Screenshots

image

Error Logs

No response

Desktop

No response

Additional context

Additionally, we should not enable claiming for child nodes in this setup. The recommended deployment strategy is that only top-level parent Agents are claimed to Cloud. By having child Agents stream to such parent Agents, they will automatically report through that parent. Also note that the k8sState Agent that is installed, is not claimed directly either.

I recommend that we remove the child related parameters.

sashwathn commented 3 months ago

@ralphm : Do you have any updates on this bug and have we already taken care of it?

sashwathn commented 3 months ago

@ralphm : Can you please have this assigned to backend / SRE and get this done?