search

netdevopsbr / netbox-proxbox

Netbox Plugin for integration between Proxmox and Netbox
Apache License 2.0
338 stars 50 forks source link

Interfaces are updated event though it's not needed #94

Closed MrBE4R closed 1 year ago

MrBE4R commented 1 year ago

Hi,

Due to some inconsistencies between the following lines : https://github.com/netdevopsbr/netbox-proxbox/blob/v0.0.5/netbox_proxbox/proxbox_api/updates/virtual_machine.py#L310 https://github.com/netdevopsbr/netbox-proxbox/blob/v0.0.5/netbox_proxbox/proxbox_api/updates/virtual_machine.py#L327

The plugin detect that it should update the interfaces.

We should either force .lower() or .upper() on both to avoid false positive.

Cheers.

emersonfelipesp commented 1 year ago

Hi @MrBE4R could you please review if it is ok like the way I did? I kept the regex considering lower case and if it matches, I use .upper() as I think it may be better readable. Thank you already!

MrBE4R commented 1 year ago

Hi @emersonfelipesp that's what I did to correct our instance.

Cheers