netenglabs / suzieq

Using network observability to operate and design healthier networks
https://www.stardustsystems.net/
Apache License 2.0
792 stars 106 forks source link

ospf summarize produces KeyError exception #100

Closed jopietsch closed 4 years ago

jopietsch commented 4 years ago

I have not updated the test data, but I thought that should only affect mlag

(suzieq) jpiet@a1:/tmp/pycharm_project_304/suzieq$ python3 suzieq/cli/suzieq-cli  -c ~/multidc.yml ospf summarize --format=json
Error running command: 'deviceCnt'
------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jpiet/.local/share/virtualenvs/suzieq-zI29E9ll/lib/python3.7/site-packages/nubia/internal/cmdbase.py", line 448, in run_cli
    return fn(**kwargs)
  File "/tmp/pycharm_project_304/suzieq/suzieq/cli/sqcmds/OspfCmd.py", line 104, in summarize
    self._init_summarize()
  File "/tmp/pycharm_project_304/suzieq/suzieq/cli/sqcmds/command.py", line 196, in _init_summarize
    namespace=self.namespace,
  File "/tmp/pycharm_project_304/suzieq/suzieq/sqobjects/ospf.py", line 32, in summarize
    return self.engine_obj.summarize(**kwargs)
  File "/tmp/pycharm_project_304/suzieq/suzieq/engines/pandas/ospf.py", line 73, in summarize
    self._post_summarize()
  File "/tmp/pycharm_project_304/suzieq/suzieq/engines/pandas/engineobj.py", line 270, in _post_summarize
    if self.ns[ns][check_empty_col] == 0:
KeyError: 'deviceCnt'
------------------------------------------------------------
ddutt commented 4 years ago

Fixed with commit 7bc0d19cca5ea8cfbd36cc1c10194d84dde89fdc