netenglabs / suzieq

Using network observability to operate and design healthier networks
https://www.stardustsystems.net/
Apache License 2.0
792 stars 106 forks source link

Mlag systemId and domainId are the same thing #219

Closed anubisg1 closed 3 years ago

anubisg1 commented 4 years ago

as per title, the two objects are the same thing and one of them should be deleted while the other kept

ddutt commented 3 years ago

I use the systemID to store the system MAC in case of NXOS and EOS. DomainID which is used by NXOS and EOS is blank for Cumulus. Therefore, having both is OK.

anubisg1 commented 3 years ago

So, what do those things represent? That part isn't clear.

If are the same thing, should we abstract and keep one? If they aren't the same, what's the difference between the two?

ddutt commented 3 years ago

So, AFAIK, NXOS and EOS have two separate things: domainID is user-specified and systemMAC is determined by the NOS itself(?). Cumulus has only thing, the systemMAC which it calls systemID. Thats why we need both systemID (user-specified in Cumulus, system determined in NXOS/EOS) and domainID(user-specified in NXOS/EOS, unused in Cumulus).

Does that make better sense why we need both?

anubisg1 commented 3 years ago

Ok I understand. Btw, on nx-os the system Mac (or virtual Mac address used by the vPC cluster) is derived by the vPC domain ID. It's a static Mac address with the last 2 digits being the vPC domain