Interface parser fixes - Githubissues

netenglabs / suzieq

Using network observability to operate and design healthier networks

https://www.stardustsystems.net/

Apache License 2.0

787 stars 104 forks source link

Interface parser fixes #839

Closed ddutt closed 1 year ago

ddutt commented 1 year ago

This patch addresses two fixes:

NXOS parser didn't record the timestamp of the link flap. At some point during parsing fixes this got accidentally dropped
IOS interface parser recorded adminState as is when the operational state was down. Instead the adminState should be down only when the words "administratively disabled" is in the state string.

Both were problems reported by user. Manual testing confirmed that the fix is in, and that before the fixes the output was wrong.

Using the NXOS testbed, flap a link and ensure that the statusChangeTimestamp field updates correctly.
Using IOS testbed, find a link with notConnected state and confirm that the adminState is up (because it is administratively up).

These fixes need to go in the 0.20.0 release

[X] I have read the comments and followed the CONTRIBUTING.md.
[X] I have explained my PR according to the information in the comments or in a linked issue.
[X] My PR source branch is created from the develop branch.
[X] My PR targets the develop branch.
[X] All my commits have --signoff applied