In case the PR contains an enhancement or a new platform/service support, some tests have to be added for the new functionality:
any fix or enhancement SHOULD include relevant new tests or test updates, if any tests need updating.
a new platform support MUST include the relevant input files similar to what we have in tests/integration/sqcmds/-input directories, along with the relevant tests in the tests/integration/sqcmds/-samples dir. That list MUST include the all.yml file fully filled out.
any new service (or table) addition MUST include comments about what network OS are supported (along with version) with this command along with test samples for those platforms and input files in the *-input dir
For additional information about tests, follow this link
Description
If the same uncaolesced file has more than one timestamp in the same file we might have issues when coalesced and uncaolesced data coexists in the data-directory.
In order to avoid the problem above, we must force the timestamp of all records written to be the same. Since all the records to write will have the same timestamp, we are going to set that timestamp also for the deletions. If instead no data was returned from the device (f.e. the device was unreachable) we use the current timestamp for the deleted records.
Type of change
Bug fix (non-breaking change which fixes an issue)
New Behavior
All the deletions in the same uncaolesced file will have the same timestamp
Contrast to Current Behavior
A new timestamp for each deleted record will be present in the same uncoalesced file
Double Check
[x] I have read the comments and followed the CONTRIBUTING.md.
[x] I have explained my PR according to the information in the comments or in a linked issue.
[x] My PR source branch is created from the develop branch.
Test inclusion requirements
In case the PR contains an enhancement or a new platform/service support, some tests have to be added for the new functionality:
For additional information about tests, follow this link
Description
If the same uncaolesced file has more than one timestamp in the same file we might have issues when coalesced and uncaolesced data coexists in the data-directory.
In order to avoid the problem above, we must force the timestamp of all records written to be the same. Since all the records to write will have the same timestamp, we are going to set that timestamp also for the deletions. If instead no data was returned from the device (f.e. the device was unreachable) we use the current timestamp for the deleted records.
Type of change
New Behavior
All the deletions in the same uncaolesced file will have the same timestamp
Contrast to Current Behavior
A new timestamp for each deleted record will be present in the same uncoalesced file
Double Check
developbranch.developbranch.--signoffapplied