netenglabs / suzieq

Using network observability to operate and design healthier networks
https://www.stardustsystems.net/
Apache License 2.0
780 stars 104 forks source link

Poller status normalize #882

Closed ddutt closed 1 year ago

ddutt commented 1 year ago

This` patch introduces a stringified version of the status in sqPoller. Instead of showing status codes such as 127, 200 etc., it shows strings such as "Command Not Found", "OK" etc. To this end, we've replaced the column status with an augmented column, statusStr, that contains the status string. Command filters such as "status=fail" work as before.

In addition, query-str didn't work correctly for sqPoller. This patch makes it function like the other commands.

Test inclusion requirements

all sqPoller tests have been updated, including sqPoller describe.

Discussion: Benefits and Drawbacks

The change is backwards-compatible, except for the bug fix to query-str which makes it function like the other commands.

Proposed Release Note Entry

sqPoller show now shows a status string instead of a numeric code, making it easier for users to understand what the error is in polling.