Due to a quirk of my testing, I had forced the transport for EOS devices to always be REST. This obviously doesn't work in all situations, as was reported in issue #875 . This patch fixes the code.
Type of change
Bug fix and documentation update.
New Behavior
EOS hosts will assume the transport is ssh unless otherwise specified in the device section of the inventory file.
Contrast to Current Behavior
EOS hosts were assumed to always be contacted via the REST API independent of what the device section of the SuzeieQ inventory file said.
Discussion: Benefits and Drawbacks
Not everyone turns on REST API, and if those users used Ansible source, SuzieQ would be unable to poll those devices. Now, the user can specify the transport via the device section in the SuzieQ inventory file, subject to the caveat that with Ansible source, the device and auth sections cannot be specified per host or group of hosts..
Changes to the Documentation
updated docs included in this patch.
Proposed Release Note Entry
BREAKING CHANGE: With Ansible sources in the inventory file, ssh is assumed to be the default transport, including for EOS devices for which prior versions had forced the version to be REST.
[X] I have read the comments and followed the CONTRIBUTING.md.
[X] I have explained my PR according to the information in the comments or in a linked issue.
[X] My PR source branch is created from the develop branch.
Description
Due to a quirk of my testing, I had forced the transport for EOS devices to always be REST. This obviously doesn't work in all situations, as was reported in issue #875 . This patch fixes the code.
Type of change
Bug fix and documentation update.
New Behavior
EOS hosts will assume the transport is ssh unless otherwise specified in the device section of the inventory file.
Contrast to Current Behavior
EOS hosts were assumed to always be contacted via the REST API independent of what the device section of the SuzeieQ inventory file said.
Discussion: Benefits and Drawbacks
Not everyone turns on REST API, and if those users used Ansible source, SuzieQ would be unable to poll those devices. Now, the user can specify the transport via the device section in the SuzieQ inventory file, subject to the caveat that with Ansible source, the device and auth sections cannot be specified per host or group of hosts..
Changes to the Documentation
updated docs included in this patch.
Proposed Release Note Entry
BREAKING CHANGE: With Ansible sources in the inventory file, ssh is assumed to be the default transport, including for EOS devices for which prior versions had forced the version to be REST.
developbranch.developbranch.--signoffapplied