This PR updates the documentation where the rest-certfile and rest-certkey were mentioned to their actual name. Additionally we change the default behavior of loading the certificates included in the suzieq package if the user don't provide any.
Type of change
Please delete options that are not relevant.
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update
New Behavior
If the rest server is set to use https but the rest-certfile and rest-certkey files are not provided we won't load anymore the certificates included in the package (which are expired in any case).
Discussion: Benefits and Drawbacks
Major benefit: we force the user to set the correct files and we avoid any unwanted launch of the server using the default ones.
Drawback: the user now need to have to generate (or already have) the certificate files to run the rest server with https
Comments
Include additional comments about the this pull request
Double Check
[x] I have read the comments and followed the CONTRIBUTING.md.
[x] I have explained my PR according to the information in the comments or in a linked issue.
[x] My PR source branch is created from the develop branch.
Description
This PR updates the documentation where the
rest-certfileandrest-certkeywere mentioned to their actual name. Additionally we change the default behavior of loading the certificates included in the suzieq package if the user don't provide any.Type of change
Please delete options that are not relevant.
New Behavior
If the rest server is set to use https but the
rest-certfileandrest-certkeyfiles are not provided we won't load anymore the certificates included in the package (which are expired in any case).Discussion: Benefits and Drawbacks
Major benefit: we force the user to set the correct files and we avoid any unwanted launch of the server using the default ones.
Drawback: the user now need to have to generate (or already have) the certificate files to run the rest server with https
Comments
Include additional comments about the this pull request
Double Check
developbranch.developbranch.--signoffapplied