netenglabs / suzieq

Using network observability to operate and design healthier networks
https://www.stardustsystems.net/
Apache License 2.0
780 stars 104 forks source link

[Bug]: Trace page return abolute url in stead of relative on trace images #905

Closed PieterL75 closed 1 year ago

PieterL75 commented 1 year ago

Suzieq version

0.21.0

Install Type

hand deployed python

Python version

3.9

Impacted component

suzieq-gui

Steps to Reproduce

deploy suzieq-gui on a relative path

Expected Behavior

the link opens with a relative url to the fqdn. https://hostname/suzieq/?variables

Observed Behavior

the link is rewritten to https://hostname/?variables

Screenshots

Additional Context

This is done in the get_base_url(): https://github.com/netenglabs/suzieq/blob/develop/suzieq/gui/stlit/guiutils.py#L112

The logic there is not quite ok, it should just return "?variable=value", and let the browser handle the relative path