netenglabs / suzieq

Using network observability to operate and design healthier networks
https://www.stardustsystems.net/
Apache License 2.0
780 stars 104 forks source link

Path improv #909

Closed ddutt closed 1 year ago

ddutt commented 1 year ago

Handle path when the source is not in ARP or as interface on a polled node, by seeking the SVI associated with that source.

Type of change

Enhancement

New Behavior

Without this patch, if you provide a source IP address that is not in the arpnd table or as the address of an interface on a polled device, the command fails with "invalid src:...". With this patch, we find the SVI associated with the IP and start tracing from that node's SVI.

If we cannot find an SVI, we flag the error: "unable to find a source node to start for "

Discussion: Benefits and Drawbacks

This is a useful feature for many people using path because the source's ARP entry may have timed out, people are testing a hypothetical source etc.

Changes to the Documentation

None.

Proposed Release Note Entry

ENHANCEMENT: path now supports specifying a source IP that may not be in the ARPND table. We determine the SVI node(s) associated with the IP and start the trace from there. Furthermore, the error message associated with a source IP whose source node we cannot locate is made more user-friendly now.

Double Check