sq-poller: Fix reference to undefined self.prompt in _ssh_connect - Githubissues

netenglabs / suzieq

Using network observability to operate and design healthier networks

https://www.stardustsystems.net/

Apache License 2.0

775 stars 105 forks source link

sq-poller: Fix reference to undefined self.prompt in _ssh_connect #926

Closed cgb closed 1 month ago

cgb commented 4 months ago

Description

_ssh_connect was refactored in PR #877 and introduced a reference to self.prompt before prompt was defined.

This resulted in the error:

suzieq.poller.worker.nodes.node - ERROR - Unable to create persistent SSH session for 1.2.3.4 due to 'IosXENode' object has no attribute 'prompt'

Type of change

Bug fix (non-breaking change which fixes an issue)

Comments

I've defined self.prompt after call to super() but it might make sense to set before call.

Double Check

[x] I have read the comments and followed the CONTRIBUTING.md.
[x] I have explained my PR according to the information in the comments or in a linked issue.
[x] My PR source branch is created from the develop branch.
[x] My PR targets the develop branch.
[x] All my commits have --signoff applied