netenglabs / suzieq

Using network observability to operate and design healthier networks
https://www.stardustsystems.net/
Apache License 2.0
791 stars 105 forks source link

Add vcenter as inventory source #939

Closed tgupta3 closed 1 month ago

tgupta3 commented 4 months ago

Related Issue

issue #928

Description

Add vcenter support to suzieq. This will fetch the relevant VMs and their IPs that can be used to collect required data. The VM should have a custom attribute key (default is suzieq), the value of the key doesn't matter, in order for it to be part of the inventory.

Dependency added - pyvnomi

Type of change

Please delete options that are not relevant.

New Behavior

A new vcenter source can be added like this

sources:
- name: vsphere-devices
  type: vcenter
  url: https://<url_vcenter>
  username: <trim>
  password: plain:<trim>
  ssl-verify: False
  attributes:
    - "monitored"

Discussion: Benefits and Drawbacks

Vmware is commonly used in on-prem. This would allow monitoring of linux devices without specifying the devices individually. The change is backwards compatible.

Proposed Release Note Entry

Add vcenter source for inventory.

Double Check

ddutt commented 4 months ago

@tgupta3 Can you please rebase to latest deveop?

tgupta3 commented 4 months ago

@tgupta3 Can you please rebase to latest deveop?

Done