netenglabs / suzieq

Using network observability to operate and design healthier networks
https://www.stardustsystems.net/
Apache License 2.0
775 stars 105 forks source link

[Bug]: sq-poller timeout type mismatch with https transport #956

Closed gioccher closed 1 month ago

gioccher commented 1 month ago

Suzieq version

0.23.0

Install Type

container

Python version

3.8

Impacted component

sq-poller

Steps to Reproduce

use https transport

snippet from inventory.yml

devices:
- name: arista
  transport: https
  devtype: eos
  port: 443

Expected Behavior

[WORKER 0]: 2024-05-28 20:31:59,207 - suzieq.poller.worker.nodes.node - WARNING - eos supplied for 10.1.2.3:443
[WORKER 0]: 2024-05-28 20:31:59,447 - suzieq.poller.worker.nodes.node - INFO - 10.1.2.3:443 exec: ['show version', 'show hostname']
[WORKER 0]: 2024-05-28 20:31:59,697 - suzieq.poller.worker.inventory.inventory - INFO - Added node device.example.net:443 of type eos

Observed Behavior

[WORKER 0]: 2024-05-28 20:23:02,758 - suzieq.poller.worker.nodes.node - WARNING - eos supplied for 10.1.2.3:443
[WORKER 0]: 2024-05-28 20:23:02,758 - suzieq.poller.worker.nodes.node - ERROR - Unable to connect to 10.1.2.3:443, error: timeout parameter cannot be of <class 'int'> type, please use 'timeout=ClientTimeout(...)'
[WORKER 0]: 2024-05-28 20:23:02,758 - suzieq.poller.worker.nodes.node - INFO - Connection to 10.1.2.3:443 will be retried from 2024-05-28 20:24:02.758817

Screenshots

Additional Context