netenglabs / suzieq

Using network observability to operate and design healthier networks
https://www.stardustsystems.net/
Apache License 2.0
787 stars 104 forks source link

[Housekeeping]: ciscoconfparse is deprecated #960

Open mpenning opened 1 month ago

mpenning commented 1 month ago

Proposed Changes

Please note that you're using ciscoconfparse. Consider ciscoconfparse2.

However, there is an API change between ciscoconfparse and ciscoconfparse2.

If interested, I will help rewrite the necessary parts of suzieq for the migration. Please respond to this github issue if you want (or don't want) to start the work.

Justification

ciscoconfparse is retired and will get no more bug fixes.

ciscoconfparse2 handles JunOS-style configs better (I found several bugs in ciscoconfparse JunOS brace parsing); furthermore it searches heavily-nested configs such as JunOS and PanOS much better.