search

netfishers-onl / BLT

BLT The BGP Linkstate Topographer
24 stars 8 forks source link

node infos always shown at the top #6

Open lukastribus opened 8 years ago

lukastribus commented 8 years ago

Node infos (when clicking on a node) are always shown at the top of the document.

However, when the map is bigger than the screen, there are scrollbars and when we are not at the top of the document, the node info box is basically hidden and we have to scroll to the top to see it.

It would be better to show it close to the actual node, or within the current focus.

AlainMoretti commented 8 years ago

I presume you are aware of this : the modal window is draggable. Thus you can place it wherever you want in the main window. When you click elsewhere, it disappears and next time it will pop up exactly where it has been hidden previously.

This being said I understand your issue. Can you confirm that dragging the modal window is not convenient and you need that it pops up near the node you are clicking on ?

lukastribus commented 8 years ago

Hi Alain,

yes I do know about that, but it isn't convenient for a number of reason, like if I move the window somewhere else, I will just have the same issue with the node that previously was fine (a node at the top of the topology). I'm literally moving the problem around.

Even if BLT would remember the window location on a per-node basis (which it doesn't), it would be a lot of work move the windows around for every node (we already have to do this for the node itself, we shouldn't have to do the same job for the box as well).

I think the best solution would be to display the box near the node.

AlainMoretti commented 8 years ago

OK Lukas, makes sense, I will fix this.

AlainMoretti commented 8 years ago

Hi Lukas, I have just post this commit Some users prefer a fixed location for the 'routerbox'. But your issue is perfectly valid, that is the reason why I had to find an agreement : routerbox still pops up at the top of main window but it is much easier to drag it now since a right click relocates it immediately.

Let me know if I can close the issue.

lukastribus commented 8 years ago

I would like to test it, but I don't know how to build blt from source, would you provide some instructions? I have the feeling I will also need this for the bgp keepalive issue.

AlainMoretti commented 8 years ago

You can build BLT using Maven, and doing this inside Eclipse is the way to go if you want to modify/understand the code. This being said, I will post release 0.4.5 with latest fixes tonight.

lukastribus commented 8 years ago

Ok, I just gave it a run.

Yes, the right click relocation is faster, but if the window does not show at all in the current focused area of the map, it is still strange behavior and not really intuitive. Do the other users prefer a fixed location, even though that location is completely out of focus? I'm trying to understand what exactly they gain from this behavior in a completely out-of-focus situation.

AlainMoretti commented 8 years ago

I agree, it is not intuitive... I have to take some time to find a better way to handle this, open the routerbox close to the clicked object may be a good idea.

Le mer. 18 mai 2016 à 10:30, Lukas Tribus notifications@github.com a écrit :

Ok, I just gave it a run.

Yes, the right click relocation is faster, but if the window does not show at all in the current focused area of the map, it is still strange behavior and not really intuitive. Do the other users prefer a fixed location, even though that location is completely out of focus? I'm trying to understand what exactly they gain from this behavior in a completely out-of-focus situation.

— You are receiving this because you commented.

Reply to this email directly or view it on GitHub https://github.com/netfishers-onl/BLT/issues/6#issuecomment-219960330

Alain Moretti