netfishers-onl / Netshot

Network Configuration and Compliance Management
http://www.netfishers.onl/netshot
242 stars 57 forks source link

charset not defined #259

Closed anli77 closed 1 year ago

anli77 commented 1 year ago

Hi,

When creating a custom driver for Arista EOS to support downloading an archive from the device, it seems there is an issue with the download function, the call always complains about charset not defined, and that seems to come from this:

https://github.com/netfishers-onl/Netshot/blob/cca878e84d7a1203e056b799bde7cd80f0465e07/src/main/resources/interfaces/driver-loader.js#L535

From commit: https://github.com/netfishers-onl/Netshot/commit/cca878e84d7a1203e056b799bde7cd80f0465e07

The charset variable passed is not defined in scope of the download function, and there is no way to pass it in that I can find?

BR /Anders.

SCadilhac commented 1 year ago

bc864df68d971e24768312d605b4bc138bec5840 should fix this