search

netflie / whatsapp-cloud-api

The first PHP API to send and receive messages using a cloud-hosted version of the WhatsApp Business Platform
https://netflie.es/portfolio/whatsapp-business-cloud-api-php-sdk/
MIT License
484 stars 177 forks source link

Allow multiple entries and changes within one webhook call #132

Closed arneee closed 1 year ago

arneee commented 1 year ago

As written in this discussion: https://github.com/netflie/whatsapp-cloud-api/discussions/129 whe webhook call might contain several changes if Facebook decides to batch them. Currently all but the first one are discarded.

This PR introduces a new readAll() method which returns all provided notifications.

aalbarca commented 1 year ago

Hey @arneee great job! Thanks.

Could you document the new feature in the README?

Thanks!

arneee commented 1 year ago

done

arneee commented 1 year ago

Hi, can we merge this? @aalbarca Thanks!

CeloGomesBR commented 1 year ago

I think it´s important to merge ASAP.

arneee commented 1 year ago

@aalbarca it's a little frustrating, can you just make the changes you would like to have for these things? Functionality and tests are there since August.

I've already seen Meta batching our messages, so I will use my private fork for now, but I recommend you to merge this soon since you are probably missing a lot of messages in production right now... I would actually consider this library broken at the moment.

aalbarca commented 1 year ago

Hi @arneee once again thank you for your support to the community.

I'm sorry if it's frustrating but I'm waiting you remove the commit which is broken the pipelines.

Why haven't you deleted it if it's too important for you?

PR will merged in https://github.com/netflie/whatsapp-cloud-api/pull/148