search

netflie / whatsapp-cloud-api

The first PHP API to send and receive messages using a cloud-hosted version of the WhatsApp Business Platform
https://netflie.es/portfolio/whatsapp-business-cloud-api-php-sdk/
MIT License
456 stars 166 forks source link

Support for WhatsApp Interactive Lists #30

Closed robertripoll closed 1 year ago

robertripoll commented 2 years ago

Implemented support for WhatsApp Interactive Lists. TODO: Unit and integration tests.

https://developers.facebook.com/docs/whatsapp/cloud-api/guides/send-messages#interactive-messages https://documenter.getpostman.com/view/13382743/UVC5FTHT#be4781ec-b59f-4aaa-8bf9-458ff4f29650

aalbarca commented 2 years ago

Hi @robertripoll I love how the community contributing with the project. Thanks so much! Please, can you write the unit and integration tests? It is neccesary to ensure the quality of the proyect.

Update the README file with an example is also required.

Thanks!

robertripoll commented 2 years ago

Hi @netflie I just wrote the unit tests for the code changes commited in this pull request. However, I do not understand why the test is not passing. Can you please help me out?

PD: You can see the unit test I wrote here.

Thanks 😄

robertripoll commented 2 years ago

Hi @netflie I just wrote the unit tests for the code changes commited in this pull request. However, I do not understand why the test is not passing. Can you please help me out?

PD: You can see the unit test I wrote here.

Thanks 😄

@netflie bump

aalbarca commented 1 year ago

Hi @netflie I just wrote the unit tests for the code changes commited in this pull request. However, I do not understand why the test is not passing. Can you please help me out?

PD: You can see the unit test I wrote here.

Thanks smile

Tests are a great way to detect fails on our source code. The test is not passing because you class Section in line 33 you are assigning the row title instead of row id. Please fix it and the tests will be pass.

You're doing a great job. If you could write the Integration tests and update the Readme with an example of lists using God will be proud of you.

robertripoll commented 1 year ago

Hi @netflie I just wrote the unit tests for the code changes commited in this pull request. However, I do not understand why the test is not passing. Can you please help me out? PD: You can see the unit test I wrote here. Thanks smile

Tests are a great way to detect fails on our source code. The test is not passing because you class Section in line 33 you are assigning the row title instead of row id. Please fix it and the tests will be pass.

You're doing a great job. If you could write the Integration tests and update the Readme with an example of lists using ~God~ will be proud of you.

Oh wow, I have been looking through all the source code trying to understand what was failing but I was not able to... The error message wasn't clear enough to explain what was failing (and where), though.

robertripoll commented 1 year ago

@netflie why can't this pull request be accepted yet? What is going on with the CI/CD?

aalbarca commented 1 year ago

Hi @robertripoll

I fixed some issues with this PR on https://github.com/netflie/whatsapp-cloud-api/pull/58:

Thanks for your contribution!